adafruit_bme280.py: Fix the value of dig_H5 #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The calculation of dig_H5 from the calibration data did not match the definition of the data sheet and the Bosch sample code. As a result, the compensated relative humidity data could have been calculated wrong.
|
@ladyada More info over in the issue thread, #17. I'd say this is good. It has a significant effect on the reading, see below. Anything else before a merge? (@kattni same Q for you) CURRENT LIBRARY: Adafruit CircuitPython 3.1.1 on 2018-11-02; Adafruit ItsyBitsy M4 Express with samd51g19
>>> import bme280_simpletest
Temperature: 27.4 C
Humidity: 31.0 %
Pressure: 1010.2 hPa
Altitude = 25.21 meters
Temperature: 27.4 C
Humidity: 31.0 %
Pressure: 1010.2 hPa
Altitude = 25.15 metersWITH #18 : Adafruit CircuitPython 3.1.1 on 2018-11-02; Adafruit ItsyBitsy M4 Express with samd51g19
>>> import bme280_simpletest
Temperature: 27.4 C
Humidity: 40.8 %
Pressure: 1010.2 hPa
Altitude = 25.26 meters
Temperature: 27.4 C
Humidity: 40.9 %
Pressure: 1010.2 hPa
Altitude = 25.17 meters |
|
Nothing from me! |
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 4, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADS1x15 to 1.0.0 from 0.5.3: > Merge pull request adafruit/Adafruit_CircuitPython_ADS1x15#19 from caternuson/iss17_update Updating https://github.com/adafruit/Adafruit_CircuitPython_BluefruitSPI to 1.0.1 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitSPI#7 from adafruit/tannewt-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_BME280 to 2.2.1 from 2.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_BME280#18 from robert-hh/master Updating https://github.com/adafruit/Adafruit_CircuitPython_CharLCD to 3.0.3 from 3.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_CharLCD#23 from adafruit/pypi-readme Updating https://github.com/adafruit/Adafruit_CircuitPython_DS3231 to 2.1.2 from 2.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_DS3231#13 from adafruit/lowercase_module_name Updating https://github.com/adafruit/Adafruit_CircuitPython_TLC5947 to 1.2.0 from 1.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_TLC5947#8 from ArthurDent62/chain_TLCs Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 1.3.3 from 1.3.2: > Merge pull request adafruit/Adafruit_CircuitPython_Motor#20 from adafruit/pypi-readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calculation of dig_H5 from the calibration data did not match the
definition of the data sheet and the Bosch sample code. As a result,
the compensated relative humidity data could have been calculated wrong.