Skip to content

failed to rename display_celsius #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

dhalbert
Copy link
Contributor

@dhalbert dhalbert commented Apr 1, 2020

Failed to rename set_to_celsius() to display_celsius() to match display_fahrenheit().

@dhalbert dhalbert requested a review from jedgarpark April 1, 2020 16:00
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jedgarpark Please ensure that you update any guides that reference this. Thanks!

@kattni kattni merged commit f8766e1 into adafruit:master Apr 16, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 17, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_AMG88xx to 1.2.2 from 1.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_AMG88xx#26 from sanderch/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_CLUE to 2.2.3 from 2.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#29 from kattni/setup-py-disabled

Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90640 to 1.1.3 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MLX90640#14 from fgervais/pc-mode

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_iBBQ to 1.2.0 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_iBBQ#1 from dhalbert/display_celsius
  > build.yml: add black formatting check

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Magic_Light to 0.9.2 from 0.9.1:
  > build.yml: add black formatting check

Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 4.1.2 from 4.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_HID#51 from larsks/bug/usb_hid

Updating https://github.com/adafruit/Adafruit_CircuitPython_Logging to 1.2.3 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_Logging#15 from jimbobbennett/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_miniesptool to 0.2.2 from 0.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_miniesptool#20 from adafruit/example-rename

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_BLE_iBBQ, Adafruit_CircuitPython_BLE_Magic_Light, Adafruit_CircuitPython_BLE_MIDI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants