Skip to content

Switch to native ConnectionError #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 13, 2020
Merged

Switch to native ConnectionError #6

merged 6 commits into from
Oct 13, 2020

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Oct 8, 2020

How does this look? Do you have a test setup? I'm not sure I have a spot for the bulb.

@tannewt tannewt requested a review from dhalbert October 8, 2020 23:56
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a Magic Light. Code looks fine -- just a couple of comment changes. Thanks!

@dhalbert
Copy link
Contributor

dhalbert commented Oct 9, 2020

Hmm, it's not re-running the Actions jobs after I committed the minor changes ☹️ . I saw some failures there.

@tannewt tannewt merged commit 0561102 into master Oct 13, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 17, 2020
@evaherrada evaherrada deleted the tannewt-patch-1 branch June 21, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants