Skip to content

Fix GitHub actions issues #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 8, 2021
Merged

Fix GitHub actions issues #1

merged 3 commits into from
Apr 8, 2021

Conversation

hugodahl
Copy link
Contributor

Fixing action issues from Infrastructure issues list for GitHub action failures

@tannewt tannewt requested a review from evaherrada March 30, 2021 17:50
@evaherrada
Copy link
Collaborator

@tannewt If I remember correctly this is an issue with the python version in build.yml. Do you happen to remember which version is the right one to use (I'll make sure to make a note of it somewhere so I don't forget)

@dhalbert
Copy link
Contributor

dhalbert commented Apr 6, 2021

@tannewt If I remember correctly this is an issue with the python version in build.yml. Do you happen to remember which version is the right one to use (I'll make sure to make a note of it somewhere so I don't forget)

You need at least 3.7

@evaherrada
Copy link
Collaborator

Cool. That's what I suspected it was. Thanks!

@evaherrada
Copy link
Collaborator

Not really sure about the current failure

@dhalbert
Copy link
Contributor

dhalbert commented Apr 6, 2021

Not really sure about the current failure

This is bleak trying to use bluetoothctl without checking for it not being there. I'll check on this.

@dhalbert
Copy link
Contributor

dhalbert commented Apr 6, 2021

Uncomment and change this line to this new version in docs/conf.py:

autodoc_mock_imports = ["bleak", "digitalio", "busio"]

@evaherrada
Copy link
Collaborator

Will do. Thanks!

@tannewt tannewt merged commit 69fdf47 into adafruit:main Apr 8, 2021
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 10, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@41b2432)
74b5ec5 
Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_LYWSD03MMC to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_LYWSD03MMC#2 from adafruit/tannewt-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_LYWSD03MMC#1 from hugodahl/feature/Fix-GitHub-action-issues
  > "Increase duplicate code check threshold "
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evaherrada evaherrada Awaiting requested review from evaherrada

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hugodahl @evaherrada @dhalbert @tannewt