Skip to content

Fix use of memoryview() + bytes() #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

dhalbert
Copy link
Contributor

Concatenating a memoryview() with a bytes() no longer works as of CircuitPython 9, due to changes in MicroPython to match CPython. Thix fixes such a use.

@dhalbert dhalbert requested a review from a team February 23, 2024 16:20
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Good catch.

@dhalbert dhalbert merged commit f8e2908 into adafruit:main Feb 23, 2024
@dhalbert dhalbert deleted the no-memoryview-add branch February 23, 2024 16:26
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants