-
Notifications
You must be signed in to change notification settings - Fork 7
Using python 3.7 so sphinx is ok with __future__ #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Not sure what's happening here |
It's trying to run |
@dhalbert Ok, looks like it's passing now |
adafruit_ble_broadcastnet.py
Outdated
*reversed( | ||
list(_ble._adapter.address.address_bytes) # pylint: disable=protected-access | ||
# This line causes issues with Sphinx, so we won't run it in the CI | ||
if "GITHUB_ACTION" not in os.environ and "READTHEDOCS" not in os.environ: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I steered you a little wrong here. There is no os.environ
in CircuitPython, only in regular CPython, so this will throw an exception. So I'd add hasattr(os, "environ") to the beginning of the
if`. Also, could you test importing this library on CircuitPython
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, ok. I'll test that as soon as I make that change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for testing.
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 5.0.2 from 5.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#50 from adafruit/uart_speed Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_BroadcastNet to 0.10.1 from 0.10.0: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_BroadcastNet#12 from adafruit/discord-fix > Fixed discord invite link Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 0.11.4 from 0.11.3: > Fix README rendering Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_ImageLoad
No description provided.