Skip to content

Add Type Annotations #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 25, 2023
Merged

Add Type Annotations #14

merged 3 commits into from
Apr 25, 2023

Conversation

zachariahpifer
Copy link
Contributor

No description provided.

jepler
jepler suggested changes Apr 25, 2023
View reviewed changes
adafruit_ble_apple_media.py Outdated
Comment on lines 36 to 37
AppleMediaServiceType = Union("AppleMediaService", Type["AppleMediaService"])

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that this line of code is not evaluated by CircuitPython (where the Union type isn't available), it needs to be moved up into the try ... except ImportError block, something like

try:
    from typing import Union, Type
    AppleMediaServiceType = Union("AppleMediaService", Type["AppleMediaService"])
except ImportError:
    pass

jepler
jepler approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@jepler jepler merged commit 4998b27 into adafruit:main Apr 25, 2023
@jepler jepler mentioned this pull request Apr 25, 2023
Closed
11 tasks
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 17, 2023
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@b5354e5)
a3187f6 
Updating https://github.com/adafruit/Adafruit_CircuitPython_24LC32 to 1.0.9 from 1.0.8:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_ADXL34x to 1.12.9 from 1.12.8:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_AMG88xx to 1.2.19 from 1.2.18:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_APDS9960 to 3.1.7 from 3.1.6:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_AW9523 to 1.1.6 from 1.1.5:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action

Updating https://github.com/adafruit/Adafruit_CircuitPython_BH1750 to 1.1.7 from 1.1.6:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_BluefruitSPI to 1.1.16 from 1.1.15:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_CharLCD to 3.4.7 from 3.4.6:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 5.3.1 from 5.3.0:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_Crickit to 2.3.13 from 2.3.12:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_DHT to 4.0.1 from 4.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_DHT#91 from xgqfrms/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SSD1305 to 1.3.10 from 1.3.9:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_DPS310 to 2.1.11 from 2.1.10:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_DS1841 to 1.0.15 from 1.0.14:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_DS3231 to 2.4.18 from 2.4.17:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_DS3502 to 1.1.17 from 1.1.16:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_DymoScale to 2.0.4 from 2.0.3:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP_ATcontrol to 0.9.2 from 0.9.1:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_Fingerprint to 2.2.11 from 2.2.10:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_FocalTouch to 1.4.7 from 1.4.6:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_HX8357 to 1.3.9 from 1.3.8:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_ICM20X to 2.0.17 from 2.0.16:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_IL0373 to 1.3.18 from 1.3.17:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_IL0398 to 1.1.15 from 1.1.14:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_IL91874 to 1.2.10 from 1.2.9:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_ILI9341 to 1.3.9 from 1.3.8:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS331 to 1.0.15 from 1.0.14:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3MDL to 1.1.23 from 1.1.22:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_LPS2X to 3.0.2 from 3.0.1:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM303_Accel to 1.1.18 from 1.1.17:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action

Updating https://github.com/adafruit/Adafruit_CircuitPython_LTR390 to 1.1.13 from 1.1.12:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX31856 to 0.11.5 from 0.11.4:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX7219 to 1.5.10 from 1.5.9:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_AWS_IOT to 2.0.14 from 2.0.13:
  > Run pre-commit
  > Update pre-commit hooks
  > Merge pull request adafruit/Adafruit_CircuitPython_AWS_IOT#22 from zbauman3/zane/native-network-example
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_GC_IOT_Core to 3.2.7 from 3.2.6:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_asyncio to 0.5.20 from 0.5.19:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Apple_Media to 0.9.13 from 0.9.12:
  > Update pre-commit hooks
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Apple_Media#14 from zachariahpifer/type-annotations
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Apple_Notification_Center to 0.10.6 from 0.10.5:
  > Update pre-commit hooks
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Apple_Notification_Center#17 from HundredVisionsGuy/type-annotations
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Cycling_Speed_and_Cadence to 1.1.12 from 1.1.11:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_LYWSD03MMC to 1.0.13 from 1.0.12:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_BoardTest to 1.2.17 from 1.2.16:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_Dash_Dis to 1.1.14 from 1.1.13:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_datetime to 1.2.4 from 1.2.3:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes to 2.6.1 from 2.6.0:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32S2TFT to 1.1.7 from 1.1.6:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_FunHouse to 2.1.19 from 2.1.18:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_Gizmo to 1.3.14 from 1.3.13:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_JWT to 1.2.14 from 1.2.13:
  > Run pre-commit
  > Update pre-commit hooks
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_Ticks to 1.0.10 from 1.0.9:
  > Update pre-commit hooks
  > Merge pull request adafruit/Adafruit_CircuitPython_Ticks#10 from stefanfoulis/fix-typo-in-comment
  > Add upload url to release action

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepler jepler jepler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachariahpifer @jepler