Skip to content

Fix for adafruit_lsm6ds now beeing a package #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 28, 2020

Conversation

dglaude
Copy link
Contributor

@dglaude dglaude commented Aug 28, 2020

Not all learn guide take from the dedicated repository

There might be other, like the CLUE.

Not all learn guide take from the dedicated repository
@ladyada ladyada requested a review from dhalbert August 28, 2020 14:18
@dglaude
Copy link
Contributor Author

dglaude commented Aug 28, 2020

CLUE is not affected because it use the CLUE library... but PyLint does not accept what it was accepting before.
Also, I need to check the CPB, and keep PyLint happy too.

It seems that CPB is protected from the change in adafruit_lsm6ds because it use it's own library.
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with app and a Feather Sense. Thanks!

@dhalbert dhalbert merged commit 96d8b13 into adafruit:master Aug 28, 2020
@dglaude dglaude deleted the patch-1 branch August 28, 2020 19:18
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants