timeout and state of advertising & keyboard leds info #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
requested changes
Aug 19, 2020
adafruit_ble/__init__.py
Outdated
| @@ -162,14 +162,16 @@ def __init__(self, adapter=None): | |||
| self._current_advertisement = None | |||
| self._connection_cache = {} | |||
|
|
|||
| def start_advertising(self, advertisement, scan_response=None, interval=0.1): | |||
| def start_advertising(self, advertisement, scan_response=None, interval=0.1, timeout=0): | |||
There was a problem hiding this comment.
Use timeout=None to indicate no timeout. That is more Pythonic, and the way we do it in other similar API's. For instance, BLERadio.start_scan() uses timeout=None.
adafruit_ble/__init__.py
Outdated
| """ | ||
| Starts advertising the given advertisement. | ||
|
|
||
| :param buf scan_response: scan response data packet bytes. | ||
| If ``None``, a default scan response will be generated that includes | ||
| `BLERadio.name` and `BLERadio.tx_power`. | ||
| :param float interval: advertising interval, in seconds | ||
| :param int timeout: advertising timeout in seconds. | ||
| If 0, no timeout. |
|
Run the "black" formatter over the changed source files, to fix the build failure. |
|
Thanks for the review. Updated |
|
BTW, you can allow us to make simple edits to this or future PR's if you check a box. See: |
|
Thanks. Will do that next time. |
dhalbert
approved these changes
Aug 19, 2020
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 20, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 7.2.0 from 7.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_BLE#98 from makerdiary/master Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 0.11.6 from 0.11.5: > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#37 from adafruit/default-params Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 1.0.2 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#5 from makermelissa/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timeouttoBLERadio.start_advertisingBLERadio.advertisingpropertyReportOut.reportproperty to get keyboard leds info