Skip to content

ManufacturerData tweak to offer control over ordering of its data fields #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2020
Merged

ManufacturerData tweak to offer control over ordering of its data fields #97

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
519dbee
Changing the attribute data from a dict to an OrderedDict to enhance …
Aug 12, 2020
fb12b95
Documenting the effect of the new OrderedDict in ManufacturerData inc…
Aug 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion adafruit_ble/advertising/standard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
"""

import struct
from collections import OrderedDict

from . import (
Advertisement,
Expand Down Expand Up @@ -220,7 +221,7 @@ def __init__(
self._company_id = company_id
self._adt = advertising_data_type

self.data = {}
self.data = OrderedDict() # makes field order match order they are set in
self.company_id = company_id
encoded_company = struct.pack("<H", company_id)
if 0xFF in obj.data_dict:
Expand Down