Skip to content

Use default values when pnp_id is not supplied #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ repos:
- id: end-of-file-fixer
- id: trailing-whitespace
- repo: https://github.com/pycqa/pylint
rev: v2.17.4
rev: v3.3.0
hooks:
- id: pylint
name: pylint (library code)
Expand Down
3 changes: 2 additions & 1 deletion .pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,8 @@ valid-metaclass-classmethod-first-arg=mcs
[DESIGN]

# Maximum number of arguments for function / method
max-args=5
# Changed for this library, Adafruit_CircuitPython_BLE
max-args=9

# Maximum number of attributes for a class (see R0902).
# max-attributes=7
Expand Down
4 changes: 4 additions & 0 deletions adafruit_ble/services/standard/device_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@ def __init__(
pass
if firmware_revision is None:
firmware_revision = getattr(os.uname(), "version", None)
if pnp_id is None:
# These values are not necessarily valid according to the spec,
# but they work on Android and iOS.
pnp_id = (0x00, 0x0000, 0x0000, 0x0000)
super().__init__(
manufacturer=manufacturer,
software_revision=software_revision,
Expand Down