Skip to content

Add missing files to ReadTheDocs #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 16, 2022
Merged

Add missing files to ReadTheDocs #149

merged 6 commits into from
Jan 16, 2022

Conversation

tekktrik
Copy link
Member

Addresses Issue #148 with the following changes:

  1. Adds adafruit_blue.characteristics.float to ReadTheDocs
  2. Adds adafruit_blue.services.nordic to ReadTheDocs
  3. Changes input to VendorUUID in SpheroService class variable from str to bytes as it should be, but I ultimately decided to keep in unlisted in ReadTheDocs because the file/class is unimplmented and I couldn't find it being used in any adafruit repos.

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @tekktrik

@FoamyGuy FoamyGuy merged commit f671192 into adafruit:main Jan 16, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 17, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_asyncio to 0.5.5 from 0.5.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#13 from dhalbert/forgot-await-message

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 8.1.4 from 8.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#149 from tekktrik/doc/add-missing-files

Updating https://github.com/adafruit/Adafruit_CircuitPython_hashlib to 1.4.1 from 1.4.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_hashlib#14 from aziascreations/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants