Modified ManufacturerDataField to return a namedtuple if possible #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For linky goodness, this would fix #114 |
|
@alexwhittemore Hello alex, do you have any test code, I could test the changes to move this forward but I would like to know what were your test conditions. Thanks :) |
|
@tannewt :) now that you are working on the BLE, what do you are your thoughts regarding this PR? Thanks |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jun 12, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.5.11 from 3.5.10: > Moved default branch to main > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#115 from Anton-2/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.9.1 from 1.9.0: > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#74 from jposada202020/adding_new_example > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#73 from kattni/rotary-neopixel-example > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#71 from jposada202020/adding_new_guides Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1325 to 1.2.5 from 1.2.4: > Moved default branch to main > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.10.3 from 1.10.2: > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#38 from bjnhur/master > Redoing adafruit/Adafruit_CircuitPython_Wiznet5k#37 Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 8.0.2 from 8.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_BLE#116 from alexwhittemore/master > Moved default branch to main > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 0.14.2 from 0.14.1: > Moved default branch to main > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_Simple_Text_Display to 1.0.1 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_Simple_Text_Display#1 from jposada202020/testing_readthedocs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm definitely not convinced this covers all cases, nor am I convinced it's non-breaking, so I'm interested in feedback (but it does work neatly in my case).
If a given
Advertisementsubclass is defined with multiple fields in a singleManufacturerDataField, the current class requires it to have an array offield_names, which heretofore are unused.This PR 1) enforces that
field_namesmust be formatted properly for a namedtuple (i.e. no spaces, probably plenty of other things) and 2) returns aMDFTupleinstead of a regular tuple, with fields named as defined.Mostly, I'm not sure when lines 285+ come into play, and whether they ought to be covered by the namedtuple modification.