Skip to content

Add Adafruit Logging as a dependency #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2022
Merged

Add Adafruit Logging as a dependency #42

merged 2 commits into from
May 7, 2022

Conversation

makermelissa
Copy link
Collaborator

@makermelissa makermelissa requested a review from a team May 6, 2022 21:44
@tekktrik
Copy link
Member

tekktrik commented May 6, 2022

It looks like adafruit_logging is disabled for PyPI. Is the fix perhaps to use the CPython logging module if it's Blinka via try/except? Or should adafruit_logging be set up on PyPI?

@makermelissa
Copy link
Collaborator Author

It looks like adafruit_logging is disabled for PyPI. Is the fix perhaps to use the CPython logging module if it's Blinka via try/except? Or should adafruit_logging be set up on PyPI?

It should be set up in PyPI. That's why it depends on adafruit/Adafruit_CircuitPython_Logging#26

@tekktrik
Copy link
Member

tekktrik commented May 6, 2022

Ohhhh, my bad!

@makermelissa
Copy link
Collaborator Author

Ohhhh, my bad!

All good. :)

@makermelissa
Copy link
Collaborator Author

Ok, this one is ready now.

tekktrik
tekktrik approved these changes May 7, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@makermelissa makermelissa merged commit ab1f76e into adafruit:main May 7, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 7, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@131849a)
553a200 
Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 2.5.3 from 2.5.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#42 from makermelissa/main
  > change discord badge
  > Patch: Replaced discord badge image
  > Update .gitignore
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_Logging to 3.7.6 from 3.7.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_Logging#26 from makermelissa/main
  > change discord badge
  > Patch: Replaced discord badge image
  > Update .gitignore
  > Update Black to latest.
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_Logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tekktrik tekktrik tekktrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makermelissa @tekktrik