-
Notifications
You must be signed in to change notification settings - Fork 13
correct python version for RTD #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Let's figure out if we can avoid doing this in some way, because we changed a lot of libraries, and it would be better not to have to update this each time we want to bump versions. |
readthedocs/readthedocs.org#7814 says it is now possible with readthedocs/readthedocs.org#8453. "Docs to be updated". |
https://docs.readthedocs.io/en/stable/config-file/v2.html#python-version says Not "3.x", boo hoo. But we'd change to build:
tools:
python: "3" anyway: https://docs.readthedocs.io/en/stable/config-file/v2.html#build Could you try that? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see posts
OK, this builds, I setup a test RTD. https://test-azureiot.readthedocs.io/en/rtd-python-ver/api.html It is worth mentioning, that the OS setting is also required and the only allowed value is that one specific Ubuntu version. At some point, that's going to require touching all the repos I bet. :-/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, matches recent change merged in cookiecutter repo.
Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 2.5.1 from 2.5.0: > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#40 from askpatrickw/rtd-python-ver
fixes #39