adafruit_io#unsubscribe(group_key=xxx) should unsubscribe thegroup ke… #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix @awgrover. There is nothing further to do for the bundle. Once merged, this will automatically make it's way into the bundle which gets generated automatically each night when there are changes to any library contained within it (new version most nights) |
brentru
approved these changes
Apr 11, 2022
evaherrada
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 11, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_EMC2101 to 1.1.12 from 1.1.11: > Merge pull request adafruit/Adafruit_CircuitPython_EMC2101#22 from rivimey/convrate_docstring > Update Black to latest. > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 5.6.5 from 5.6.4: > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#88 from awgrover/unsubscribe-group-key-87 > Update Black to latest. Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Apple_Notification_Center to 0.10.0 from 0.9.7: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Apple_Notification_Center#16 from todbot/add_actions > Update Black to latest. > Fixed readthedocs build > Consolidate Documentation sections of README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #87
I have not tested this. I only noted the inconsistency of
feed_keyvsgroup_key.I would like this fix to go in the
adafruit-circuitpython-bundle-7.x-mpy, please advise if I need to submit another PR, and against which tag/branch.