validate feed keys used needs to allow periods #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavio-fernandes
force-pushed
the
fix.validate_feed_key
branch
2 times, most recently
from
0b90fc6 to
3e509c0
Compare
brentru
reviewed
May 3, 2021
flavio-fernandes
force-pushed
the
fix.validate_feed_key
branch
2 times, most recently
from
dad5971 to
b87dfd8
Compare
xadhoom
reviewed
May 3, 2021
The recently introduced validate_feed_key [0] function needs to account for cases when feed_id includes a group. For example: "sign-quotes.signtext" Fixes adafruit#71 [0]: adafruit@1e3d458
flavio-fernandes
force-pushed
the
fix.validate_feed_key
branch
from
b87dfd8 to
9392e29
Compare
brentru
approved these changes
May 5, 2021
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 6, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_RPLIDAR to 1.2.0 from 1.1.6: > Merge pull request adafruit/Adafruit_CircuitPython_RPLIDAR#17 from zlite/master > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 5.2.5 from 5.2.4: > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#73 from flavio-fernandes/fix.validate_feed_key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently introduced validate_feed_key 0 function
needs to account for cases when feed_id includes a
group. For example: "sign-quotes.signtext"
Fixes #71