BREAKING Update for ESP32S2, CPython #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
November 19, 2020 16:39
…n wifi-interfaces
…n the io interface.
|
Ok, I've been testing it. I noticed without making any changes to the code and passing in the WiFi manager, it appears to work exactly like before. When I updated it to pass in requests instead, I noticed it fixed issue adafruit/Adafruit_CircuitPython_MatrixPortal#51. I'm going to take a closer look at the code changes, but so far it is looking good. |
|
Thank you for testing! |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 21, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 5.0.1 from 4.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#54 from brentru/add-esp32spi-simpletest > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#53 from brentru/update-for-requests-s2 Updating https://github.com/adafruit/Adafruit_CircuitPython_MagTag to 1.0.5 from 1.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#18 from makermelissa/sound_bug > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#16 from caternuson/iss15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initargument now takes in aadafruit_circuitpython_requestsobject instead of awifimanagerobject.6.1.0-beta.1), CPython, and ESP32SPI (Metro AirLift M4,6.1.0-beta.1)The following libraries' constructors should also be updated to match this breaking release:
https://github.com/adafruit/Adafruit_CircuitPython_MagTag/blob/main/adafruit_magtag/network.py#L311
https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal/blob/master/adafruit_matrixportal/network.py#L315
https://github.com/adafruit/Adafruit_Blinka_PyPortal/blob/master/adafruit_pyportal.py#L625
https://github.com/adafruit/Adafruit_CircuitPython_PyPortal/blob/master/adafruit_pyportal.py#L891