Skip to content

adafruit_io_simpletest.py: fix aio_user to aio_username #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2020
Merged

adafruit_io_simpletest.py: fix aio_user to aio_username #48

merged 2 commits into from
Oct 13, 2020

Conversation

mytechnotalent
Copy link
Contributor

This PR changes the aio_user to aio_username to keep consistent with the secrets.py file.

Currently a new maker will have a default secrets.py file with aio_username and this example will break.

@brentru brentru self-requested a review October 9, 2020 15:50
@mytechnotalent
Copy link
Contributor Author

Sure @brentru I would be glad to. The problem I have now is running pylint on these files has a ton of issues. Any suggestions? I think you might have strengthened the rules after the file was created.

@brentru
Copy link
Member

brentru commented Oct 9, 2020

Thank you. The Pylint output in Actions is suppressed by the black output (https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO/pull/48/checks#step:11:1). Could you black the files so I can check out the pylint errors?

@mytechnotalent
Copy link
Contributor Author

`developer@DESKTOP-UK9RHDJ:/Adafruit_CircuitPython_AdafruitIO$ black examples/adafruit_io_simpletest.py
All done! ✨ 🍰 ✨
1 file left unchanged.
developer@DESKTOP-UK9RHDJ:
/Adafruit_CircuitPython_AdafruitIO$ pylint examples/adafruit_io_simpletest.py
************* Module adafruit_io_simpletest
examples/adafruit_io_simpletest.py:1:0: C0114: Missing module docstring (missing-module-docstring)
examples/adafruit_io_simpletest.py:31:0: C0103: Constant name "esp32_cs" doesn't conform to '(([A-Z_][A-Z0-9_])|(__.))$' pattern (invalid-name)
examples/adafruit_io_simpletest.py:32:0: C0103: Constant name "esp32_ready" doesn't conform to '(([A-Z_][A-Z0-9_]*)|(
.__))$' pattern (invalid-name)
examples/adafruit_io_simpletest.py:33:0: C0103: Constant name "esp32_reset" doesn't conform to '(([A-Z_][A-Z0-9_]
)|(.*))$' pattern (invalid-name)
examples/adafruit_io_simpletest.py:40:0: C0103: Constant name "spi" doesn't conform to '(([A-Z_][A-Z0-9_])|(__.))$' pattern (invalid-name)
examples/adafruit_io_simpletest.py:41:0: C0103: Constant name "esp" doesn't conform to '(([A-Z_][A-Z0-9_]*)|(
.__))$' pattern (invalid-name)
examples/adafruit_io_simpletest.py:43:0: C0103: Constant name "status_light" doesn't conform to '(([A-Z_][A-Z0-9_]
)|(.*))$' pattern (invalid-name)
examples/adafruit_io_simpletest.py:55:0: C0103: Constant name "wifi" doesn't conform to '(([A-Z_][A-Z0-9_])|(__.))$' pattern (invalid-name)
examples/adafruit_io_simpletest.py:59:0: C0116: Missing function or method docstring (missing-function-docstring)
examples/adafruit_io_simpletest.py:69:0: C0116: Missing function or method docstring (missing-function-docstring)
examples/adafruit_io_simpletest.py:74:0: C0116: Missing function or method docstring (missing-function-docstring)
examples/adafruit_io_simpletest.py:80:0: C0116: Missing function or method docstring (missing-function-docstring)
examples/adafruit_io_simpletest.py:86:0: C0116: Missing function or method docstring (missing-function-docstring)
examples/adafruit_io_simpletest.py:102:0: C0103: Constant name "mqtt_client" doesn't conform to '(([A-Z_][A-Z0-9_]*)|(
.__))$' pattern (invalid-name)
examples/adafruit_io_simpletest.py:110:0: C0103: Constant name "io" doesn't conform to '(([A-Z_][A-Z0-9_]
)|(.*))$' pattern (invalid-name)
examples/adafruit_io_simpletest.py:124:0: C0103: Constant name "last" doesn't conform to '(([A-Z_][A-Z0-9_])|(__.))$' pattern (invalid-name)
examples/adafruit_io_simpletest.py:131:8: C0103: Constant name "value" doesn't conform to '(([A-Z_][A-Z0-9_]*)|(
.__))$' pattern (invalid-name)
examples/adafruit_io_simpletest.py:134:8: C0103: Constant name "last" doesn't conform to '(([A-Z_][A-Z0-9_]
)|(.*))$' pattern (invalid-name)


Your code has been rated at 6.90/10 (previous run: 6.90/10, +0.00)`

@mytechnotalent
Copy link
Contributor Author

@brentru I updated all the files as requested and ran black on them. I also posted my pylint errors on the one file for an example.

Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brentru brentru merged commit f2f4e13 into adafruit:master Oct 13, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants