-
Notifications
You must be signed in to change notification settings - Fork 31
adafruit_io_simpletest.py: fix aio_user to aio_username #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adafruit_io_simpletest.py: fix aio_user to aio_username #48
Conversation
@mytechnotalent Thanks for the catch. I did a search for
Would you mind editing the PR to change |
Sure @brentru I would be glad to. The problem I have now is running pylint on these files has a ton of issues. Any suggestions? I think you might have strengthened the rules after the file was created. |
Thank you. The Pylint output in Actions is suppressed by the black output (https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO/pull/48/checks#step:11:1). Could you black the files so I can check out the pylint errors? |
`developer@DESKTOP-UK9RHDJ: Your code has been rated at 6.90/10 (previous run: 6.90/10, +0.00)` |
@brentru I updated all the files as requested and ran black on them. I also posted my pylint errors on the one file for an example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 4.2.1 from 4.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#48 from mytechnotalent/fix-aio_user-to-aio_username
This PR changes the
aio_user
toaio_username
to keep consistent with the secrets.py file.Currently a new maker will have a default secrets.py file with
aio_username
and this example will break.