Skip to content

Update simpletest examples to detect boards with built-in ESP32 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2019

Conversation

brentru
Copy link
Member

@brentru brentru commented Apr 30, 2019

This PR proposes updating examples to try/except on board.D#. This will let examples run on boards like the PyPortal/Metro M4 without editing the example code.

Examples tested with a PyPortal and an Feather M4 + AirLift Breakout

@brentru brentru added the enhancement New feature or request label Apr 30, 2019
@brentru brentru requested a review from a team April 30, 2019 16:50
@ladyada
Copy link
Member

ladyada commented Apr 30, 2019

you want it the other way, try the special names first?

@brentru
Copy link
Member Author

brentru commented Apr 30, 2019

@ladyada Updated to try ESP_ pin definitions first

@ladyada ladyada merged commit ac455da into adafruit:master Apr 30, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 30, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_EPD to 2.0.1 from 2.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_EPD#18 from kattni/readme-update
  > Merge pull request adafruit/Adafruit_CircuitPython_EPD#15 from kattni/readme-update
  > Merge pull request adafruit/Adafruit_CircuitPython_EPD#13 from kattni/add-213-mono
  > Merge pull request adafruit/Adafruit_CircuitPython_EPD#12 from kattni/example-update
  > Merge pull request adafruit/Adafruit_CircuitPython_EPD#10 from ladyada/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_HX8357 to 1.0.1 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_HX8357#3 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7735 to 1.0.1 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7735#3 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7735R to 1.0.1 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7735R#4 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7789 to 1.0.1 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7789#3 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 1.2.4 from 1.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#22 from brentru/update-simpletest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants