add different device ID #45
Conversation
RuntimeError Exception prohibits code to proceed. Tested with (apds)GY-9960 board.
|
@dertobias could you modify the code to print the value of I think it would be best if we added a new ID to a list of valid IDs to check rather than removing the logic to check them entirely. |
|
you're right. it prints 168. So adding it as device_id2 0xa8 worked on my end :) |
|
@dertobias If you're up to it can you change this PR (or submit a new one) to refactor DEVICE_ID to be a list or tuple and then have the logic use something |
Changed IDs to tuple and added new chip ID
|
@FoamyGuy patch works for me :) |
There was a problem hiding this comment.
Looks good to me. Thanks for the addition @dertobias!
I tested this successfully on a CLUE
Updating https://github.com/adafruit/Adafruit_CircuitPython_APDS9960 to 3.1.10 from 3.1.9: > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#45 from dertobias/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.4.4 from 7.4.3: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#174 from vladak/loop_is_connected Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
RuntimeError Exception prohibits code to proceed.
Tested with (apds)GY-9960 board.