adding rotation modifier for gestures #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def rotation(self, new_rotation): | ||
| if new_rotation in [0, 90, 180, 270]: | ||
| self._rotation = new_rotation | ||
|
|
There was a problem hiding this comment.
I think this should throw a ValueError if the input is not in [0,90,180,270] - it will just ignore it silently as written
jerryneedell
requested changes
Jun 10, 2020
There was a problem hiding this comment.
Nice additions! This works well - tested with an apds9960_breakout on a grandcentral_m4.
I think it should be made clear that only values of 0,90,180,270 are permitted and throw an error (ValueError) if something else is input. A note should also be added to the Doc String that only these 4 values are accepted.
| @property | ||
| def rotation(self): | ||
| """Gesture rotation offset""" | ||
| return self._rotation |
There was a problem hiding this comment.
Indicate that only [0,90,180,270] are acceptable
|
Agree'd thank you for catching that @jerryneedell. I will make those changes later on tonight. |
…eptable values in docstring.
jerryneedell
approved these changes
Jun 13, 2020
Closed
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jun 19, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_APDS9960 to 2.2.0 from 2.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#26 from FoamyGuy/rotation_modifier Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3MDL to 1.1.3 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_LIS3MDL#10 from kattni/combo-example Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 7.0.0 from 6.1.5: > Merge pull request adafruit/Adafruit_CircuitPython_BLE#89 from dhalbert/easier-prefixes Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_BroadcastNet to 0.10.0 from 0.9.0: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_BroadcastNet#10 from dhalbert/match_prefixes Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Radio to 0.3.0 from 0.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Radio#12 from dhalbert/match_prefixes > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Radio#10 from adafruit/add-build-yml Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Adafruit to 1.1.0 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Adafruit#4 from dhalbert/match-prefix Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Eddystone to 0.10.0 from 0.9.0: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Eddystone#8 from dhalbert/match_prefixes > build.yml: add black formatting check Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.7.1 from 2.7.0: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#51 from caternuson/iss50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a rotation offset that can be used to adjust the values returned by
gesture()in case your sensor is mounted in a different orientation. Solves #25