Add offsets, example, fix acceleration. #2
Conversation
|
Calibration math updated as per change requested in adafruit/Adafruit_CircuitPython_ADXL34x#34. |
adafruit_adxl37x.py
Outdated
| from typing import Tuple, Optional | ||
|
|
||
| # This is only needed for typing | ||
| import busio # pylint: disable=unused-import |
There was a problem hiding this comment.
Is the pylint disable required? Looks like the library is used so it should be okay without it.
There was a problem hiding this comment.
I copied it from the other lib, I'll try running it without.
There was a problem hiding this comment.
It passes without it! I'll remove it, let me know what to with the type hint so I can do a single commit.
| return x, y, z | ||
|
|
||
| @property | ||
| def range(self) -> int: |
There was a problem hiding this comment.
I'm torn for what to do here. As is, it technically works, so the correct typing should be -> None. Is the intention to allow for silently ignoring the lack of implementation, as opposed to raising NotImplementedError?
There was a problem hiding this comment.
@tekktrik You're the expert here! I'll defer to you on this one. It throws the NotImplementedError when attempting to use it, because you can't set the range on this chip.
There was a problem hiding this comment.
Hmmm.... if you want the behavior to be that it throws NotImplementedError on both getting and setting, then I'd say it's fine to leave the typing as is because there's never really going to be a case where someone is expecting to get int and actually gets anything at all, so the potentially future-safe implementation of returning int seems fine. If you want the get functionality of range to not fail but also not give anything useful, I would probably type this as returning None. Either implementation works so up to you!
There was a problem hiding this comment.
I think we can leave it as it is for now then, and if it comes up in the future as an issue, we'll look at updating it!
There was a problem hiding this comment.
So is the decision to raise Not ImplementatedError from this property getter as well?
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADXL34x to 1.12.0 from 1.11.12: > Merge pull request adafruit/Adafruit_CircuitPython_ADXL34x#34 from kattni/offset Updating https://github.com/adafruit/Adafruit_CircuitPython_ADXL37x to 1.1.0 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_ADXL37x#2 from kattni/offset Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 5.1.6 from 5.1.5: > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#84 from dhalbert/circuitpython_typing Updating https://github.com/adafruit/Adafruit_CircuitPython_Debug_I2C to 1.2.8 from 1.2.7: > Merge pull request adafruit/Adafruit_CircuitPython_Debug_I2C#12 from dhalbert/circuitpython-typing > Fixed readthedocs build
No description provided.