-
Notifications
You must be signed in to change notification settings - Fork 5
Minor correction to the Read The Docs #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…t) - (Optional)..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'm not sure what you are asking about.
I think maybe @Timeline8 was referring to the way the docs render the max_size argument default: In the function signature it seems to be able to figure out the value of I don't know why RTD / sphinx is able to fill in the variable value for one and not the other. We could hardcode |
And my secondary comment was how these two didn't seem to mesh correctly (as @FoamyGuy correctly pointed out)... Where in the "class" line at the top is properly shows the default as 4096 but in the text below it gives the vague "_MAX_SIZE_I2C" rather than an integer number. |
Updating https://github.com/adafruit/Adafruit_CircuitPython_24LC32 to 1.1.1 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_24LC32#24 from Timeline8/doc_fix_line_226 Updating https://github.com/adafruit/Adafruit_CircuitPython_NTP to 3.2.0 from 3.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_NTP#37 from tedder/ted/configurable_cache_time_2 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Ah! Ya, signature information is determined by actually loading the code. The doc string isn't evaluated at all. That's also why address is 80 in the signature but 0x50 in the docs. You could remove the mention of the default in the doc string completely because that info is in the signature already. |
Under the I2C class for EEPROM parameters currently reads as "max_int – (Optional) " should be "max_size (int) - (Optional)"
Also I didn't know how to do it, but in the read the docs page the " Default is
_MAX_SIZE_I2C
" part reads out at literally "_MAX_SIZE_I2C" instead of like it does above in the classclass adafruit_24lc32.EEPROM_I2C(i2c_bus: busio.I2C, address: int = 80, write_protect: bool = False, wp_pin: DigitalInOut | None = None, max_size: int = 4096)¶