Used wrong variable name for IOCON #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yah, probably copy pasta. Thanks for the cleanup. Do you know how to run clang-format to pass the CI checks? |
|
No idea how to run the clang-format on this Windows machine, but it looks like there are a couple of extra spaces. I got that fixed. If it still fails CI, I will figure out the clang-format. |
|
Yep. Looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of the code were modified. This will help us understand any risks of integrating
the code.
The variable name used in setupInterrupts() is incorrect. Probably a mistake from copy/paste. There is no impact on the correctness of the code, but it is nice to have the proper variable name.
doesn't apply to a supported platform of the library please mention it.
No concerns.
strive to not break users of the code and running tests/examples helps with this
process.
Tested and working.