Port B interrupt fixes #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for spotting that. That does appear to be a misplaced parans. Also good catch on the INTCAP clearing. Do you know how to run clang-format so the CI will pass? |
|
Sorry for the delay, ran the formatter now @caternuson |
|
Awesome. Thanks for the fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A code bug seems to have snuck into line 225, causing it to read Port A's INTF register when it should've actually read Port B. Updated line 213 similarly for clarity.
Also, fixes so that if it were a Port B pin that triggered the interrupt, the appropriate INTCAP register will be read. Previously, only the Port A INTCAP register was always read.