Override wire begin for ESP8266 to provide PINs #38
Conversation
| /** | ||
| * Initializes the MCP23017 given its HW selected address, see datasheet for Address selection. | ||
| */ | ||
| void Adafruit_MCP23017::begin(uint8_t addr, uint8_t sda_pin, uint8_t scl_pin) { |
There was a problem hiding this comment.
Don't pass in pins. Instead, pass in a Wire object. See comment here.
There was a problem hiding this comment.
Why pass wire object? then wire needs to be exposed to calling library also, now this can be hidden when only pins are provided.
given the multiple pull requests & issues opened i think this is the more preffered way of the community.
There was a problem hiding this comment.
we wont' accept it, you must make the Wire object and pass it in, thats is the official Arduino library methodology
|
hi we will not merge as this is best fixed by espressif - please comment here to request they add a function to do it |
|
Closing. I think the issue thread linked above addresses this. That plus being able to pass in a wire instance should support this feature. |
Describe the scope of your change--i.e. what the change does and what parts
of the code were modified. This will help us understand any risks of integrating
the code.
The scope of the change is to implement an begin override to provide 'custom' pins e.g. required for ESP8266.
Describe any known limitations with your change. None that i'm aware of. basic functionality shall remain as is.
Please run any tests or examples that can exercise your modified code. Verified this locally with I2C.