-
Notifications
You must be signed in to change notification settings - Fork 43
feat: Expose release count option #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Expose release count option #53
Conversation
Extension: |
This is awesome, thank you! I can definitely accept this. A couple of requests:
And a question:
|
Yes I will take a look at the tests and add the option to the readme. And I also agree with you on the 3rd point, I will implement this as well. |
I have added documentation about the option to the readme and have added that the changelog gets overridden when releaseCount is 0. But unfortunately, I couldn't figure out how to test the changelog regeneration. |
I'll get this in on Monday, and see if I can add a test. Either way, I'll release it then. Thanks again for the PR! Much appreciated <3 |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #53 +/- ##
=======================================
Coverage 97.40% 97.40%
=======================================
Files 27 27
Lines 1194 1194
=======================================
Hits 1163 1163
Misses 31 31
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Okay sounds great :) |
Released as 11.1.0. Please let me know if there are any issues, and thanks again for the PR! |
Hey, thanks for the fork it offers really useful additions to standard-version!
One feature that is missing for us is that we can't regenerate the complete changelog since the releaseCount option isn't passed through to conventional-changelog so I added it with this PR. If you have any feedback on it feel free to share.
Hope we can make it an addition to the package since also other people seem to miss it as well (Fixes conventional-changelog#719)