-
Notifications
You must be signed in to change notification settings - Fork 43
fix: Add debug messages for exclusions during bump lifecycle #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add debug messages for exclusions during bump lifecycle #131
Conversation
Code has been modified to include debug messages in the bump lifecycle. When a filename is ignored by Git or is not a file, the program will now log a debug-level message.
I had a wrong gitignore file. These debug outputs would have helped me to identify the cause more quickly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for this! Sorry it took so long to get to it - I missed the notification somehow.
Looks good to me (with a couple suggestions left inline).
At the moment, the format check is failing so I can't merge it in. I would normally just fix this for you, but I'm travelling at the moment.
If you can push a commit that runs the formatter (just do npm run format:fix
), I'd be happy to merge it. Otherwise, I'll do it when I'm back on deck in a week or two.
Thanks again!
I like to contribute something if I can. |
…e-version#131) * chore: Add debug messages for exclusions in lifecycle bump Code has been modified to include debug messages in the bump lifecycle. When a filename is ignored by Git or is not a file, the program will now log a debug-level message. * chore(absolute-version#131): Update formatting * chore(absolute-version#131): Improve debug messages for exclusions during bump lifecycle
* test: add openapi crlf mocks * test: add openapi lf mocks * feat: add support for openapi version bumping (almost identical to yaml-updater) * test: OpenAPI updater tests * fix: Add debug messages for exclusions during bump lifecycle (#131) * chore: Add debug messages for exclusions in lifecycle bump Code has been modified to include debug messages in the bump lifecycle. When a filename is ignored by Git or is not a file, the program will now log a debug-level message. * chore(#131): Update formatting * chore(#131): Improve debug messages for exclusions during bump lifecycle * chore(master): release 12.3.0 (#139) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * docs: add documentation about how to bump OpenAPI version --------- Co-authored-by: Markus Schulte <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Timothy Jones <[email protected]>
Code has been modified to include debug messages in the bump lifecycle. When a filename is ignored by Git or is not a file, the program will now log a debug-level message.