example: Add LevelSensor using Ethernet #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
More refactoring to come... if someone can test with Arduino's WiFi's shield. |
It was tested on Arduino mega256 with W5100 shield and FC-28 soil moisture analog sensor Change-Id: Ibb78e12d024df8bcbe522e013734e40a3a623b16 Origin: https://github.com/TizenTeam/webthing-esp8266 Bug: WebThingsIO#23 Signed-off-by: Philippe Coval <[email protected]>
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
8d6586b to
681ef8d
Compare
|
Which part would you like tested with a WiFi shield? It looks like everything in this PR right now is ethernet-specific |
|
yes this PR can be merged, but I'd like then to merge WiFi and Eth classes to make it more generic... I can test Eth not WiFi part and I don't want to break it ;) |
|
Great! Sounds good to me |
hobinjk
approved these changes
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was tested on Arduino mega256 with W5100 shield and FC-28 soil moisture analog sensor
Change-Id: Ibb78e12d024df8bcbe522e013734e40a3a623b16
Origin: https://github.com/TizenTeam/webthing-esp8266
Signed-off-by: Philippe Coval [email protected]