Skip to content

Figure captions and whitespace #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks
lheagy opened this issue Jan 2, 2023 · 2 comments
Closed
2 tasks

Figure captions and whitespace #87

lheagy opened this issue Jan 2, 2023 · 2 comments
Labels
1st edition Planned for inclusion in 1st print edition

Comments

@lheagy
Copy link
Contributor

lheagy commented Jan 2, 2023

Many of the figures have the label caption-hack. This removes margin space, and in some places led to overlapping figure and caption. Instead, we should

  • remove the caption-hack tag
  • trim whitespace on figures

.caption-hack img {
margin-bottom: -30px;
}

image

This has been addressed in Ch 3 with #76, but will need to be addressed elsewhere.

@lheagy lheagy mentioned this issue Jan 2, 2023
@lheagy lheagy changed the title Ch 3: Figure 17 "Melting data from a wide to long data format Figure captions and whitespace. Jan 4, 2023
@lheagy lheagy changed the title Figure captions and whitespace. Figure captions and whitespace Jan 4, 2023
@joelostblom
Copy link
Contributor

Just a note that the caption-hack CSS class might still be needed for any images that are automatically generated by code blocks, such as our Altair charts. See the following for details as to why and the alternative approach we can use:

@trevorcampbell trevorcampbell added the 1st edition Planned for inclusion in 1st print edition label Sep 17, 2023
@trevorcampbell
Copy link
Contributor

I believe this is handled now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1st edition Planned for inclusion in 1st print edition
Projects
None yet
Development

No branches or pull requests

3 participants