Skip to content

happiness.csv vs canlang.csv in path example in reading chapter #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trevorcampbell opened this issue Nov 10, 2023 · 1 comment · Fixed by #317
Closed

happiness.csv vs canlang.csv in path example in reading chapter #279

trevorcampbell opened this issue Nov 10, 2023 · 1 comment · Fixed by #317
Labels
1st edition Planned for inclusion in 1st print edition enhancement New feature or request low-priority

Comments

@trevorcampbell
Copy link
Contributor

trevorcampbell commented Nov 10, 2023

We originally used happiness because it was based on our week 2 worksheet, but we should keep it consistent with the rest of the book and that chapter and use canlang

do in R version too

Edit: looking again at the figure, it seems it's based off our dsci-100-student repo structure after a few weeks of work. Should either update the fig to correspond to the current names of things or replace with a more generic figure.

I'm leaning towards just having a more generic figure to avoid having to keep it in sync

@trevorcampbell trevorcampbell added enhancement New feature or request low-priority 1st edition Planned for inclusion in 1st print edition labels Nov 10, 2023
@trevorcampbell
Copy link
Contributor Author

also specifically denote the "root" folder in the figure, since we refer to "root" in the text beforehand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1st edition Planned for inclusion in 1st print edition enhancement New feature or request low-priority
Development

Successfully merging a pull request may close this issue.

1 participant