Skip to content

Fig 1.5 uses multiline expr before introduction #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trevorcampbell opened this issue Aug 2, 2023 · 3 comments · Fixed by #317
Closed

Fig 1.5 uses multiline expr before introduction #190

trevorcampbell opened this issue Aug 2, 2023 · 3 comments · Fixed by #317
Labels
1st edition Planned for inclusion in 1st print edition bug Something isn't working

Comments

@trevorcampbell
Copy link
Contributor

We should only use multiline stuff after 1.8 in the book

@trevorcampbell trevorcampbell added the bug Something isn't working label Aug 2, 2023
@trevorcampbell
Copy link
Contributor Author

The relevant source file is in source/img/key_files/code-figures.pptx -- but the code is stored as a static image that isn't editable, so I can't fix this without knowing which editor the original figures were created from

@trevorcampbell
Copy link
Contributor Author

Ah no I think they were created by rendering a code block in jupyterbook and then screenshotting it.

Unfortunately jupyterbook has changed its syntax highlighting since that first build, so we probably need to regenerate all the "syntax helper" figures

@trevorcampbell
Copy link
Contributor Author

See also #191 for other syntax fig issue that should be closed at the same time as this one

@trevorcampbell trevorcampbell added the 1st edition Planned for inclusion in 1st print edition label Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1st edition Planned for inclusion in 1st print edition bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant