Skip to content

Simplify ZPP code #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Simplify ZPP code #16

wants to merge 1 commit into from

Conversation

twose
Copy link

@twose twose commented Sep 4, 2020

No description provided.

@TysonAndre
Copy link
Owner

array_is_list(array): bool was proposed in php#4886 (comment) , but I'm opposed to doing that - is_numeric() doesn't throw for objects, for example. This is implementing is_list(mixed): bool, and should not throw for non-array types - it's already as short as is practical

This is why the tests fail with your proposed change.

@TysonAndre TysonAndre closed this Sep 4, 2020
@twose twose deleted the patch-1 branch September 4, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants