Skip to content

Opcache idea: Combine is_int($x) || is_string($x) #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TysonAndre opened this issue Nov 12, 2019 · 0 comments
Open

Opcache idea: Combine is_int($x) || is_string($x) #6

TysonAndre opened this issue Nov 12, 2019 · 0 comments

Comments

@TysonAndre
Copy link
Owner

TysonAndre commented Nov 12, 2019

<?php
function f1($x, $y) {
    var_export($y === null || is_int($y));
    return $y === null || is_int($y);
}

The TYPE_CHECK can be combined if the pattern is recognized

For~/php-8.0.0-dev-install/bin/php -d opcache.file_cache= -d opcache.opt_debug_level=0x20000 test.php

f1: ; (lines=12, args=2, vars=2, tmps=1)
    ; (after optimizer)
    ; /path/to/test.php:3-6
L0 (3):     CV0($x) = RECV 1
L1 (3):     CV1($y) = RECV 2
L2 (4):     INIT_FCALL 1 96 string("var_export")
L3 (4):     T2 = TYPE_CHECK (null) CV1($y)
L4 (4):     T2 = JMPNZ_EX T2 L6
L5 (4):     T2 = TYPE_CHECK (long) CV1($y)
L6 (4):     SEND_VAL T2 1
L7 (4):     DO_ICALL
L8 (5):     T2 = TYPE_CHECK (null) CV1($y)
L9 (5):     T2 = JMPNZ_EX T2 L11
L10 (5):    T2 = TYPE_CHECK (long) CV1($y)
L11 (5):    RETURN T2

TysonAndre pushed a commit that referenced this issue May 31, 2021
The following opcodes would be generated:

  ...
  BB1:
  0003 JMP BB3

  BB2:
  0004 INIT_FCALL 1 96 string("chr")
  0005 #10.T3 [long] = SR #3.CV0($int) [long] #7.CV2($i) ...
  0006 #11.T4 [long] RANGE[0..127] = BW_AND #10.T3 [long] ...
  0007 #12.T3 [long] RANGE[128..255] = BW_OR #11.T4 [long] ...
  0008 SEND_VAL #12.T3 [long] RANGE[128..255] 1
  0009 #13.V3 [ref, rc1, rcn, any] = DO_ICALL
  0010 ASSIGN_OP (CONCAT) #6.CV1($out) [rc1, rcn, string]
  0011 ADD #7.CV2($i)... int(7) #7.CV2($i) ... -> #15.CV2($i) ...

  BB3:
  0012 #8.T4 [long] = SR #3.CV0($int) #7.CV2($i) [long, double]
  0013 #9.T3 [bool] RANGE[0..1] = IS_SMALLER int(128) #8.T4
  0014 JMPNZ #9.T3 [bool] RANGE[0..1] BB2
  ...

Main changes are:
1. SR opcode covers new path in function zend_jit_long_math_helper().
2. BW_AND and BW_OR opcodes are supported. See macro LONG_OP.
3. Function zend_jit_concat_helper() is added to support ASSIGN_OP
opcode. Speficically, CONCAT and FAST_CONCAT is supported for statements
"$out .= ...".
4. New path is covered in function zend_jit_cmp_long_long() by
IS_SMALLER opcode.
5. New path is covered in macros ZVAL_PTR_DTOR and ZVAL_DTOR_FUNC when
leaving.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant