Skip to content

Rounded Border TextField Elevation #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 12, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions packages/angular/cli/commands/update-impl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,15 +104,18 @@ export class UpdateCommand extends SchematicCommand<UpdateCommandSchema> {
this.logger.info(`Using package manager: '${packageManager}'`);

// Special handling for Angular CLI 1.x migrations
if (options.migrateOnly === undefined && options.from === undefined) {
if (!options.all && packages.length === 1 && packages[0].name === '@angular/cli') {
const oldConfigFilePath = findUp(oldConfigFileNames, process.cwd());
if (oldConfigFilePath) {
if (
options.migrateOnly === undefined &&
options.from === undefined &&
!options.all &&
packages.length === 1 &&
packages[0].name === '@angular/cli' &&
this.workspace.configFile &&
oldConfigFileNames.includes(this.workspace.configFile)
) {
options.migrateOnly = true;
options.from = '1.0.0';
}
}
}

this.logger.info('Collecting installed dependencies...');

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,16 @@ function _pluginOptionsOverrides(

function _createAotPlugin(
wco: WebpackConfigOptions,
options: any,
useMain = true,
extract = false,
options: AngularCompilerPluginOptions,
i18nExtract = false,
) {
const { root, buildOptions } = wco;

const i18nInFile = buildOptions.i18nFile
? path.resolve(root, buildOptions.i18nFile)
: undefined;

const i18nFileAndFormat = extract
const i18nFileAndFormat = i18nExtract
? {
i18nOutFile: buildOptions.i18nFile,
i18nOutFormat: buildOptions.i18nFormat,
Expand All @@ -79,7 +78,7 @@ function _createAotPlugin(
}

let pluginOptions: AngularCompilerPluginOptions = {
mainPath: useMain ? path.join(root, buildOptions.main) : undefined,
mainPath: path.join(root, buildOptions.main),
...i18nFileAndFormat,
locale: buildOptions.i18nLocale,
platform: buildOptions.platform === 'server' ? PLATFORM.Server : PLATFORM.Browser,
Expand Down Expand Up @@ -108,7 +107,7 @@ export function getNonAotConfig(wco: WebpackConfigOptions) {
};
}

export function getAotConfig(wco: WebpackConfigOptions, extract = false) {
export function getAotConfig(wco: WebpackConfigOptions, i18nExtract = false) {
const { tsConfigPath, buildOptions } = wco;

const loaders: any[] = [NgToolsLoader];
Expand All @@ -123,7 +122,7 @@ export function getAotConfig(wco: WebpackConfigOptions, extract = false) {

return {
module: { rules: [{ test, use: loaders }] },
plugins: [_createAotPlugin(wco, { tsConfigPath }, true, extract)]
plugins: [_createAotPlugin(wco, { tsConfigPath }, i18nExtract)]
};
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ async function execute(options: ExtractI18nBuilderOptions, context: BuilderConte
scripts: false,
styles: false,
},
buildOptimizer: false,
i18nLocale: options.i18nLocale,
i18nFormat: options.i18nFormat,
i18nFile: outFile,
Expand Down
3 changes: 2 additions & 1 deletion packages/ngtools/webpack/src/interfaces.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
*/

import { logging, virtualFs } from '@angular-devkit/core';
import { CompilerOptions } from '@angular/compiler-cli';
import * as fs from 'fs';
import * as ts from 'typescript';

Expand Down Expand Up @@ -59,7 +60,7 @@ export interface AngularCompilerPluginOptions {
contextElementDependencyConstructor?: ContextElementDependencyConstructor;

// Use tsconfig to include path globs.
compilerOptions?: ts.CompilerOptions;
compilerOptions?: CompilerOptions;

host?: virtualFs.Host<fs.Stats>;
platformTransformers?: ts.TransformerFactory<ts.SourceFile>[];
Expand Down