Skip to content

Upgrade from extract-text-webpack-plugin to mini-css-extract-plugin #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
info-lvsys opened this issue Jun 9, 2018 · 1 comment · Fixed by #650
Closed

Upgrade from extract-text-webpack-plugin to mini-css-extract-plugin #645

info-lvsys opened this issue Jun 9, 2018 · 1 comment · Fixed by #650

Comments

@info-lvsys
Copy link
Contributor

extract-text-webpack-plugin is now deprecated for Webpack 4 - see home page: https://github.com/webpack-contrib/extract-text-webpack-plugin :

"Since webpack v4 the extract-text-webpack-plugin should not be used for css. Use mini-css-extract-plugin instead."

Are you planning on upgrading to the mini-css-extract-plugin?

If not, any way you could show the changes to make to the webpack.vendor.config.js ? (We're struggling with and I suspect many others are)

Thanks for any input :)

@info-lvsys
Copy link
Contributor Author

info-lvsys commented Jun 12, 2018

We implemented it, so I submitted two PRs for your review. Tested the build too. It's a very minor change all in all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant