Skip to content

Latest Clean Build - fails #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
OceansideBill opened this issue Oct 8, 2017 · 1 comment
Closed

Latest Clean Build - fails #434

OceansideBill opened this issue Oct 8, 2017 · 1 comment

Comments

@OceansideBill
Copy link
Contributor

I'm running node v8.6 and npm 5.4.2.

Pulled a copy of the latest changes to my local machine.
Immediately failed on npm install.
Reran npm rebuild node-sass - didn't help
Deleted my node_modules folder and did a fresh npm install.
This worked, for npm install.

npm run build:dev then failed.

Getting an errors TS2345 and TS2034.

I'm holding off updating my fork
build-dev
@MarkPieszak
Copy link
Member

Yeah those exact ones are from ngx-translate updates Olivier's made.
The TranslateLoader itself requires HttpClient as a dependency now, instead of regular Http.

All those updates are coming soon, I have the 5.0 branch that'll be merged to master soon with all its updates.

This breaking change above is one of them: https://github.com/MarkPieszak/aspnetcore-angular2-universal/pull/437/files#diff-1c8f345fff94162c0c0a8ae7c14bad47R30

@MarkPieszak MarkPieszak mentioned this issue Oct 10, 2017
Merged
MarkPieszak added a commit that referenced this issue Nov 2, 2017
@MarkPieszak
feat(Angular 5.0): update engine-etc for angular 5.0 & Domino (#437)
901300a 
* feat(5.0): update engine-etc for angular 5.0-rc1

WIP - More updates to come

* remove ng 4 references

* update source maps for faster HMR builds

* use aspnetcore-engine & misc updates and fixes

* update to 5.0 official

Closes #434
Closes #435
Closes #430
Closes #424
BillSheldon-HunterIndustries pushed a commit to BillSheldon-HunterIndustries/aspnetcore-angular2-universal that referenced this issue Jan 17, 2018
@MarkPieszak @BillSheldon-HunterIndustries
feat(Angular 5.0): update engine-etc for angular 5.0 & Domino (Trilon…
ce70c6a 
…IO#437)

* feat(5.0): update engine-etc for angular 5.0-rc1

WIP - More updates to come

* remove ng 4 references

* update source maps for faster HMR builds

* use aspnetcore-engine & misc updates and fixes

* update to 5.0 official

Closes TrilonIO#434
Closes TrilonIO#435
Closes TrilonIO#430
Closes TrilonIO#424
BillSheldon-HunterIndustries pushed a commit to BillSheldon-HunterIndustries/aspnetcore-angular2-universal that referenced this issue May 15, 2018
@MarkPieszak @BillSheldon-HunterIndustries
feat(Angular 5.0): update engine-etc for angular 5.0 & Domino (Trilon…
188094d 
…IO#437)

* feat(5.0): update engine-etc for angular 5.0-rc1

WIP - More updates to come

* remove ng 4 references

* update source maps for faster HMR builds

* use aspnetcore-engine & misc updates and fixes

* update to 5.0 official

Closes TrilonIO#434
Closes TrilonIO#435
Closes TrilonIO#430
Closes TrilonIO#424
BillSheldon-HunterIndustries pushed a commit to BillSheldon-HunterIndustries/aspnetcore-angular2-universal that referenced this issue May 15, 2018
@MarkPieszak @BillSheldon-HunterIndustries
feat(Angular 5.0): update engine-etc for angular 5.0 & Domino (Trilon…
5f899b4 
…IO#437)

* feat(5.0): update engine-etc for angular 5.0-rc1

WIP - More updates to come

* remove ng 4 references

* update source maps for faster HMR builds

* use aspnetcore-engine & misc updates and fixes

* update to 5.0 official

Closes TrilonIO#434
Closes TrilonIO#435
Closes TrilonIO#430
Closes TrilonIO#424
BillSheldon-HunterIndustries pushed a commit to Hunter-Industries/aspnetcore-angular2-universal that referenced this issue May 16, 2018
@MarkPieszak @BillSheldon-HunterIndustries
feat(Angular 5.0): update engine-etc for angular 5.0 & Domino (Trilon…
66f655d 
…IO#437)

* feat(5.0): update engine-etc for angular 5.0-rc1

WIP - More updates to come

* remove ng 4 references

* update source maps for faster HMR builds

* use aspnetcore-engine & misc updates and fixes

* update to 5.0 official

Closes TrilonIO#434
Closes TrilonIO#435
Closes TrilonIO#430
Closes TrilonIO#424
BillSheldon-HunterIndustries pushed a commit to BillSheldon-HunterIndustries/aspnetcore-angular2-universal that referenced this issue Jun 8, 2018
@MarkPieszak @OceansideBill
feat(Angular 5.0): update engine-etc for angular 5.0 & Domino (Trilon…
7c0166f 
…IO#437)

* feat(5.0): update engine-etc for angular 5.0-rc1

WIP - More updates to come

* remove ng 4 references

* update source maps for faster HMR builds

* use aspnetcore-engine & misc updates and fixes

* update to 5.0 official

Closes TrilonIO#434
Closes TrilonIO#435
Closes TrilonIO#430
Closes TrilonIO#424
BillSheldon-HunterIndustries pushed a commit to BillSheldon-HunterIndustries/aspnetcore-angular2-universal that referenced this issue Jun 8, 2018
@MarkPieszak @OceansideBill
feat(Angular 5.0): update engine-etc for angular 5.0 & Domino (Trilon…
9da48b3 
…IO#437)

* feat(5.0): update engine-etc for angular 5.0-rc1

WIP - More updates to come

* remove ng 4 references

* update source maps for faster HMR builds

* use aspnetcore-engine & misc updates and fixes

* update to 5.0 official

Closes TrilonIO#434
Closes TrilonIO#435
Closes TrilonIO#430
Closes TrilonIO#424
BillSheldon-HunterIndustries pushed a commit to BillSheldon-HunterIndustries/aspnetcore-angular2-universal that referenced this issue Jun 8, 2018
@MarkPieszak @OceansideBill
feat(Angular 5.0): update engine-etc for angular 5.0 & Domino (Trilon…
57cfc06 
…IO#437)

* feat(5.0): update engine-etc for angular 5.0-rc1

WIP - More updates to come

* remove ng 4 references

* update source maps for faster HMR builds

* use aspnetcore-engine & misc updates and fixes

* update to 5.0 official

Closes TrilonIO#434
Closes TrilonIO#435
Closes TrilonIO#430
Closes TrilonIO#424
BillSheldon-HunterIndustries pushed a commit to BillSheldon-HunterIndustries/aspnetcore-angular2-universal that referenced this issue Jun 8, 2018
@MarkPieszak @OceansideBill
feat(Angular 5.0): update engine-etc for angular 5.0 & Domino (Trilon…
2936dee 
…IO#437)

* feat(5.0): update engine-etc for angular 5.0-rc1

WIP - More updates to come

* remove ng 4 references

* update source maps for faster HMR builds

* use aspnetcore-engine & misc updates and fixes

* update to 5.0 official

Closes TrilonIO#434
Closes TrilonIO#435
Closes TrilonIO#430
Closes TrilonIO#424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MarkPieszak @OceansideBill