Skip to content

algorithm : Added Quick Select algorithm #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

algorithm : Added Quick Select algorithm #7

wants to merge 14 commits into from

Conversation

Owais28
Copy link
Contributor

@Owais28 Owais28 commented Sep 24, 2022 •
edited
Loading

Describe your change:

  • Add an algorithm

@Owais28
> # Welcome to the TypeScript community
227bc2c 
>
> ### Describe your change:
> * [x]  Add an algorithm?
> * [ ]  Fix a bug or typo in an existing algorithm?
> * [ ]  Documentation change?
>
> ### Checklist:
> * [x]  I have read [CONTRIBUTING.md](https://github.com/TheAlgorithms/Javascript/blob/master/CONTRIBUTING.md).
> * [x]  This pull request is all my own work -- I have not plagiarized.
> * [x]  I know that pull requests will not be merged if they fail the automated tests.
> * [x]  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
> * [x]  All new JavaScript files are placed inside an existing directory.
> * [x]  All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
>   **Example:**`UserProfile.js` is allowed but `userprofile.js`,`Userprofile.js`,`user-Profile.js`,`userProfile.js` are not
> * [x]  All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
> * [x]  If this pull request resolves one or more open issues then the commit message contains `Fixes: #{$ISSUE_NO}`.
@Owais28
Added Quick Select Algorithm #6
cc8c0c7
@Owais28 Owais28 changed the title algorithm : Added Quick Select algorithm #6 algorithm : Added Quick Select algorithm Sep 24, 2022
@Panquesito7 Panquesito7 added the enhancement New feature or request label Sep 25, 2022
Panquesito7
Panquesito7 reviewed Sep 25, 2022
View reviewed changes
appgurueu
appgurueu reviewed Sep 25, 2022
View reviewed changes
Data-structures/QuickSelect.ts

const QuickSelect = (items: Array<number>, kth: number): number => {
// eslint-disable-line no-unused-vars
if (kth < 1 || kth > items.length) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider making kth 0-based for consistency with JS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

help needed

@appgurueu
Copy link
Contributor

appgurueu commented Sep 25, 2022 •
edited
Loading

Please keep the Abs out of this PR. There already is plenty of noise due to the tooling (which should be added along with a CI in a separate PR).

@Owais28
Copy link
Contributor Author

Owais28 commented Sep 26, 2022

I have reverted the previous commit (17b48fd)

appgurueu
appgurueu reviewed Sep 26, 2022
View reviewed changes
@Owais28 Owais28 closed this Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu left review comments

@Panquesito7 Panquesito7 Panquesito7 left review comments

@raklaptudirm raklaptudirm Awaiting requested review from raklaptudirm raklaptudirm is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Owais28 @appgurueu @Panquesito7