Skip to content

algorithm: nth Fibonacci Number #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Oct 7, 2022
Merged

algorithm: nth Fibonacci Number #29

merged 16 commits into from
Oct 7, 2022

Conversation

MohdFaisalBidda
Copy link
Contributor

Added Math function

  • Added Fibonacci

raklaptudirm
raklaptudirm requested changes Oct 3, 2022
View reviewed changes
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove changes to .build and tsconfig.json. Move your code to /Maths/ instead of /src/Maths/.

appgurueu
appgurueu reviewed Oct 3, 2022
View reviewed changes
appgurueu
appgurueu reviewed Oct 3, 2022
View reviewed changes
appgurueu
appgurueu reviewed Oct 3, 2022
View reviewed changes
@MohdFaisalBidda MohdFaisalBidda requested review from appgurueu and raklaptudirm and removed request for raklaptudirm and appgurueu October 3, 2022 17:33
@MohdFaisalBidda MohdFaisalBidda requested review from appgurueu and removed request for raklaptudirm and appgurueu October 3, 2022 18:10
@MohdFaisalBidda MohdFaisalBidda removed the request for review from raklaptudirm October 4, 2022 09:52
@MohdFaisalBidda MohdFaisalBidda changed the title Fibonacci Added: Fibonacci Math Function Oct 4, 2022
@MohdFaisalBidda
Copy link
Contributor Author

MohdFaisalBidda commented Oct 4, 2022 •
edited
Loading

Remove changes to .build and tsconfig.json. Move your code to /Maths/ instead of /src/Maths/.

  • changed tsconfig.json and Moved the code to /Maths/.

@MohdFaisalBidda MohdFaisalBidda requested review from raklaptudirm and appgurueu and removed request for appgurueu and raklaptudirm October 5, 2022 19:34
raklaptudirm
raklaptudirm previously approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name fibonacci value is misleading. What you are fining is the nth Fibonacci number. Rename your function and comments accordingly.

@raklaptudirm raklaptudirm requested a review from appgurueu October 7, 2022 07:39
@MohdFaisalBidda
Update Fibonacci.test.ts
1a8f9aa 
indentation fixed
@MohdFaisalBidda MohdFaisalBidda requested review from appgurueu and raklaptudirm and removed request for raklaptudirm and appgurueu October 7, 2022 09:00
@MohdFaisalBidda MohdFaisalBidda requested review from appgurueu and removed request for raklaptudirm October 7, 2022 09:35
@raklaptudirm raklaptudirm changed the title Added: Fibonacci Math Function algorithm: nth Fibonacci Number Oct 7, 2022
@raklaptudirm raklaptudirm merged commit 4d0d714 into TheAlgorithms:master Oct 7, 2022
@MohdFaisalBidda MohdFaisalBidda deleted the Fibonacci branch October 7, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MohdFaisalBidda @appgurueu @raklaptudirm