Skip to content

Feat: Fibonacci Series #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 22, 2023
Merged

Feat: Fibonacci Series #205

merged 6 commits into from
Oct 22, 2023

Conversation

MohdFaisalBidda
Copy link
Contributor

@appgurueu @Panquesito7 @raklaptudirm I have implemented Fibonacci Series (Math/series) please review my PR

appgurueu
appgurueu reviewed Oct 20, 2023
View reviewed changes
Copy link
Contributor

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the ideal API for this is an infinite generator which generates subsequent fibonacci numbers; people can easily stuff that in an array if they want, but they don't need to.

Otherwise mostly fine; I think this should probably replace / be used in the implementation of the first function in https://github.com/TheAlgorithms/TypeScript/blob/master/maths/fibonacci.ts, esp. if it gets turned into a generator: Then you just have to "select" the n-th element from the generator.

@MohdFaisalBidda
Copy link
Contributor Author

MohdFaisalBidda commented Oct 20, 2023 •
edited
Loading

@appgurueu
So I have to implement a infinite generator for Fibonacci numbers and use that in the first function of nthFibonacci function.

@appgurueu
Copy link
Contributor

@appgurueu So I have to implement a infinite generator for Fibonacci numbers and use that in the first function of nthFibonacci function.

I think that would be the best solution, yes.

@MohdFaisalBidda
Copy link
Contributor Author

@Panquesito7 @raklaptudirm anyone review my code

@raklaptudirm raklaptudirm merged commit deaa0af into TheAlgorithms:master Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7 Panquesito7 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MohdFaisalBidda @appgurueu @raklaptudirm @actions-user