Skip to content

Feat : Add Binary No.s #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2023
Merged

Feat : Add Binary No.s #191

merged 1 commit into from
Oct 14, 2023

Conversation

Suryac72
Copy link
Contributor

Adding a new feature to add 2 binary no.s using bit manipulation technique

@appgurueu @raklaptudirm please review my PR

appgurueu
appgurueu approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@appgurueu appgurueu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, but I'd try to shorten the variable names, and get rid of the unneeded result variable. You should be able to put the .toBe('11000') on a different line if that's what you want.

@Suryac72
Copy link
Contributor Author

hi @raklaptudirm once you have time, please review the PR.

@raklaptudirm raklaptudirm merged commit 9b28624 into TheAlgorithms:master Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Suryac72 @appgurueu @raklaptudirm