feat : added tries implementation using typescript #150
Conversation
There was a problem hiding this comment.
Please get rid of redundant comments (practically all of your comments currently). A comment is redundant when all it says is already found in the code. For example:
/**
*
*
* @param word
* @param word
* @param position
* @param position
* @param letterMap
* @param letterMap
* @returns
* @returns
*
* Private method implementation to search word in letterMap of type (Trie)
*/This is redundant with the signature (and outdated even).
I'm fine with omitting comments if a method is self-explanatory (add and find don't need comments; I'd rename find to has however, and isPrefixMatch should be documented).
|
hi, @appgurueu , I removed redundant comments and package-lock.json file from my PR, please have a look. also, I document isPrefixMatch flag variable in the form of a comment, please have a look. If further modification needs to be done, let me know. thanks for figuring out my mistakes and reviewing my PR |
|
Hi @raklaptudirm, please review my PR. |
|
Your tests are failing. Also undo the deletion of the package-lock file. |
|
hi @raklaptudirm, I updated my PR |
|
Hi @appgurueu which changes i need to undo? |
|
Hi @raklaptudirm, I can see all checks have passed successfully |
|
You need to undo the deletion of the |
|
Hi @raklaptudirm, I added again package-lock.json file |
|
Add the file without changes, please. |
|
hi @raklaptudirm I added package-lock.json without any changes. just like present in master branch |
|
Hi @raklaptudirm , @appgurueu approved my PR. Please approve my PR from your end |
|
hi @raklaptudirm, my PR was approved by @appgurueu. please review my PR so that I can able to merge my PR |
|
Please be patient. Rak will get to review your PR when he has time. |
No description provided.