feat(maths): added Factors

[T1LT]

No description provided.

[appgurueu]

Please call this Factorize or FindFactors (our naming convention demands a verb).

Side note: You could speed this up to sqrt(n)

[T1LT]

Please call this Factorize or FindFactors (our naming convention demands a verb).

Side note: You could speed this up to sqrt(n)

Got it! Will add the optimization too!

[appgurueu]

I feel it would be cleaner conceptually to return a Set of factors.

[T1LT]

I feel it would be cleaner conceptually to return a Set of factors.

sure, will do!

[T1LT]

I have 2 questions:

1. how do I type the Set? Set or Set or is there a convention for this?
2. how do I write the tests for matching Sets?

[raklaptudirm]

@T1LT https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set

[T1LT]

@raklaptudirm do I have to create an Interface for it? or can is typing it as Set good enough? and what Jest matcher should I use for the tests?

[raklaptudirm]

Check the link it should have all you need.

[zFl4wless]

I improved this code base a bit and resolves the requested changes in #112
Hope you are fine with that @T1LT :)

[raklaptudirm]

Closing since #112 which was a superset of this pr was merged.