-
-
Notifications
You must be signed in to change notification settings - Fork 46.6k
Stack_using_two_Queues #9990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stack_using_two_Queues #9990
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper
commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper review
to trigger the checks for only added pull request files@algorithms-keeper review-all
to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
||
|
||
|
||
def __init__(self) : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: __init__
. If the function does not return a value, please provide the type hint as: def function() -> None:
|
||
|
||
def __init__(self) : | ||
self.insert_Queue=deque() #First Queue to be used for inserting elements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable and function names should follow the snake_case
naming convention. Please update the following name accordingly: insert_Queue
|
||
def __init__(self) : | ||
self.insert_Queue=deque() #First Queue to be used for inserting elements | ||
self.suffle_Queue=deque() #Second Queue to be used for suffling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable and function names should follow the snake_case
naming convention. Please update the following name accordingly: suffle_Queue
self.suffle_Queue=deque() #Second Queue to be used for suffling | ||
|
||
|
||
def push(self,item:int): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: push
. If the function does not return a value, please provide the type hint as: def function() -> None:
while(bool(self.suffle_Queue)==True): | ||
self.insert_Queue.append(self.suffle_Queue.popleft())#Poping the elements from the suffle queue into the insert queue in order | ||
|
||
self.insert_Queue,self.suffle_Queue=self.suffle_Queue,self.insert_Queue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable and function names should follow the snake_case
naming convention. Please update the following name accordingly: insert_Queue
Variable and function names should follow the snake_case
naming convention. Please update the following name accordingly: suffle_Queue
self.insert_Queue,self.suffle_Queue=self.suffle_Queue,self.insert_Queue | ||
|
||
|
||
def pop(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: pop
. If the function does not return a value, please provide the type hint as: def function() -> None:
return(self.suffle_Queue[0]) | ||
|
||
|
||
def printing(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: printing
. If the function does not return a value, please provide the type hint as: def function() -> None:
print(self.suffle_Queue) | ||
|
||
|
||
def size(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: size
. If the function does not return a value, please provide the type hint as: def function() -> None:
|
||
|
||
|
||
def test_stack(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: test_stack
. If the function does not return a value, please provide the type hint as: def function() -> None:
for more information, see https://pre-commit.ci
Describe your change:
Added the program for implementation of stack using two queues.
Fixes:#9987
Checklist: