-
-
Notifications
You must be signed in to change notification settings - Fork 46.6k
Segmented sieve - doctests #9945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
ad217c6
07dfc06
8a50e77
961e92a
9b59404
10a46e7
587cdc2
3df701a
f261cba
535fcdc
acbac94
9bacc25
b173e62
f15758c
8c4336c
3de3f75
496c9a9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -4,7 +4,26 @@ | |||||
|
||||||
|
||||||
def sieve(n: int) -> list[int]: | ||||||
"""Segmented Sieve.""" | ||||||
""" | ||||||
Segmented Sieve. | ||||||
|
||||||
Examples: | ||||||
>>> sieve(8) | ||||||
[2, 3, 5, 7] | ||||||
|
||||||
>>> sieve(27) | ||||||
[2, 3, 5, 7, 11, 13, 17, 19, 23] | ||||||
|
||||||
""" | ||||||
|
||||||
if n < 0: | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would be OK to combine these into a single What happens on floating point input? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Output
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice doctest to add. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @cclauss question is off topic. For some reason, my old commits end up in pull requests. I don’t understand why this is so? Every time I make a new branch and they still get there. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I will look in a few hours… |
||||||
word = f"Number should not be negative n {n}" | ||||||
raise ValueError(word) | ||||||
|
||||||
if n == 0: | ||||||
word = f"Number should not be zero n {n}" | ||||||
raise ValueError(word) | ||||||
|
||||||
in_prime = [] | ||||||
start = 2 | ||||||
end = int(math.sqrt(n)) # Size of every segment | ||||||
|
@@ -42,4 +61,9 @@ def sieve(n: int) -> list[int]: | |||||
return prime | ||||||
|
||||||
|
||||||
print(sieve(10**6)) | ||||||
if __name__ == "__main__": | ||||||
import doctest | ||||||
|
||||||
doctest.testmod() | ||||||
|
||||||
print(sieve(10**6)) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a doctest where the input itself is a prime number. For example,
This is to clarify whether the algorithm includes the input number itself or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition, please make sure that the function can correctly handle negative and zero inputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tianyizheng02 corrected.