-
-
Notifications
You must be signed in to change notification settings - Fork 46.6k
Fixes - #8098 all soring algorithm #9891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper
commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper review
to trigger the checks for only added pull request files@algorithms-keeper review-all
to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
@@ -0,0 +1,12 @@ | |||
def bubblesort(arr): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: bubblesort
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file Sorting/bubble_sort.py
, please provide doctest for the function bubblesort
Please provide type hint for the parameter: arr
@@ -0,0 +1,14 @@ | |||
def heapsort(arr): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: heapsort
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file Sorting/heap_sort.py
, please provide doctest for the function heapsort
Please provide type hint for the parameter: arr
@@ -0,0 +1,14 @@ | |||
def insertionsort(arr): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: insertionsort
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file Sorting/insertion_sort.py
, please provide doctest for the function insertionsort
Please provide type hint for the parameter: arr
@@ -0,0 +1,34 @@ | |||
def mergesort(arr): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: mergesort
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file Sorting/merge_sort.py
, please provide doctest for the function mergesort
Please provide type hint for the parameter: arr
if len(arr) <= 1: | ||
return arr | ||
|
||
def merge(left, right): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: merge
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file Sorting/merge_sort.py
, please provide doctest for the function merge
Please provide type hint for the parameter: left
Please provide type hint for the parameter: right
@@ -0,0 +1,20 @@ | |||
def quicksort(arr): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: quicksort
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file Sorting/quick_sort.py
, please provide doctest for the function quicksort
Please provide type hint for the parameter: arr
@@ -0,0 +1,14 @@ | |||
def selectionsort(arr): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: selectionsort
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file Sorting/selection_sort.py
, please provide doctest for the function selectionsort
Please provide type hint for the parameter: arr
for more information, see https://pre-commit.ci
Describe your change: Added various sorting algorithms in a single file for reference and easy access. The implemented sorting algorithms include QuickSort, MergeSort, BubbleSort, InsertionSort, SelectionSort, and HeapSort. This consolidation improves code organization and accessibility for future use.
Checklist: