Skip to content

added tanh function to activation functions #9854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

added tanh function to activation functions #9854

wants to merge 1 commit into from

Conversation

aggarwalayan
Copy link

@aggarwalayan aggarwalayan commented Oct 5, 2023 •
edited
Loading

Describe your change:

add algorithm for applying tanh activation function on an array.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 5, 2023
@aggarwalayan aggarwalayan reopened this Oct 5, 2023
@cclauss
Copy link
Member

cclauss commented Oct 5, 2023 •
edited
Loading

I do not like this move. tanh has a lot of other uses than as an activation function. @ChrisO345 Your thoughts?

We already have https://github.com/TheAlgorithms/Python/blob/master/maths/tanh.py

@tianyizheng02
Copy link
Contributor

@cclauss I already pointed this out in this comment. Since we already have an implementation I think it's fine to close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aggarwalayan @cclauss @tianyizheng02