Skip to content

Update CONTRIBUTING.md to match #964 #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2019

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Jul 7, 2019

Blocked by #964 Recommend the use of black, doctests, flake8, and mypy.

@TheAlgorithms TheAlgorithms deleted a comment Jul 7, 2019
@TheAlgorithms TheAlgorithms deleted a comment Jul 7, 2019
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that this looks "heavy" for first-time contributor. Later, we may need to add a section that describes the contribution flow, something like: reading the guide, writing code in certain way, automated testing for code (behind the sence) and the review process. Well, thank you for your pull request!🤩

@poyea poyea merged commit 78cd3df into master Jul 8, 2019
@poyea poyea deleted the Update-CONTRIBUTING.md-to-match-#964 branch July 8, 2019 16:04
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Update CONTRIBUTING.md to match TheAlgorithms#964

Blocked by TheAlgorithms#964

* Do not modify README or DIRECTORY file.

* Update CONTRIBUTING.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants