Simplied password_generator.py

[qckzr]

• Added main() function
• Simplified password_generator
• Formatted file according to pep 8

[cclauss]

Very cool... Thanks!

[cclauss]

Really cool ideas here! You sparked my imagination over my morning coffee. Thanks.

I approve this PR in its current form but what about...

from random import choice
from string import ascii_letters, digits, punctuation

def password_generator(length=8):
    '''
    >>> len(password_generator())
    8
    >>> len(password_generator(length=16))
    16
    >>> len(password_generator(257))
    257
    >>> len(password_generator(length=0))
    0
    >>> len(password_generator(-1))
    0
    '''
    chars = tuple(ascii_letters) + tuple(digits) + tuple(punctuation)
    return ''.join(choice(chars) for x in range(length))

Some of the logic behind these suggestions:

• Change max_length to just length because it completely determines the length of the output
• Give length a sensible default value so that users can just fire-and-forget. Perhaps this value should be higher
• Add doctests so that we can test the code by running python3 -m doctest -v other/password_generator.py
• tuples should be faster to create then lists and should take up slightly less memory
• We only need to randomize once. random.choice() should be a lighter weight operation than random.shuffle()
• password_generator() should generate a password so there is no need to create a variable named password only to get rid of it on the following line.